Skip to content

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Dec 17, 2024

WebAssembly/binaryen#7153 updated Binaryen version to 121, but bumping the version to 121 here does not pass the CI (because Binaryen version is behind by 2), so this updates the version to 120 for the moment.

@aheejin aheejin requested a review from kripken December 17, 2024 17:53
@aheejin aheejin changed the title Bump Binaryen to 121 Bump Binaryen to 120 Dec 17, 2024
@sbc100
Copy link
Collaborator

sbc100 commented Dec 17, 2024

Feel free to land this without waiting for CI if it helps unblock the rollers.

@aheejin aheejin merged commit 6fa576b into emscripten-core:main Dec 17, 2024
21 of 28 checks passed
@aheejin aheejin deleted the binaryen_121 branch December 17, 2024 18:59
aheejin added a commit to aheejin/emscripten that referenced this pull request Dec 18, 2024
WebAssembly/binaryen#7153 updated Binaryen
version to 121, and we updated it in Emscripten to 120 to make the CI
pass (emscripten-core#23197). Now that
https://chromium-review.googlesource.com/c/emscripten-releases/+/6103023
has landed, I think we can update it to 121.
aheejin added a commit that referenced this pull request Dec 18, 2024
WebAssembly/binaryen#7153 updated Binaryen
version to 121, and we updated it in Emscripten to 120 to make the CI
pass (#23197). Now that
https://chromium-review.googlesource.com/c/emscripten-releases/+/6103023
has landed, I think we can update it to 121.
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
WebAssembly/binaryen#7153 updated Binaryen
version to 121, but bumping the version to 121 here does not pass the CI
(because Binaryen version is behind by 2), so this updates the version
to 120 for the moment.
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
WebAssembly/binaryen#7153 updated Binaryen
version to 121, and we updated it in Emscripten to 120 to make the CI
pass (emscripten-core#23197). Now that
https://chromium-review.googlesource.com/c/emscripten-releases/+/6103023
has landed, I think we can update it to 121.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants